set_aspect for 3d axes should be removed

Issue #9 resolved
Kosuke Mizuno created an issue

Hi, thanks to the great library.

I report that ax.set_aspect('equal') at 175 line of drawings.py raise NotImplementedError with matplotlib>=3.1.0.

For matplotlib>=3.1.0, we should control aspects by figsize like plt.figure(figsize=(6,6)) or rect like fig.add_axes((0.0, 0.0, .5, 0.5), projection='3d'). In my understanding, even for matplotlib<3.1.0, set_aspect('equal') works incorrectly. (See: API Changes — Matplotlib 3.1.0 documentation)

Versions:

  • python 3.7.7
  • matplotlib 3.2.1
  • py_pol latest

Comments (3)

  1. JESUS DEL HOYO MUÑOZ

    Hi, thank you for your appreciation.

    We have been working with 3.2.0 and 3.2.2 versions of matplotlib and it worked without problems. However, our python version is 3.8.2, so it may be a version problem there. Anyway, we added the option of setting axis_equal=False in draw_poincare method to avoid that line if the problem perssts.

  2. Log in to comment