Aperture calculation not 100% correct

Issue #9 closed
Former user created an issue

It is ipasa = (Xrot)2 / (radiusx + 1e-15)2 + \ (Yrot)2 / (radiusy2 + 1e-15) < 1

In def circle(self, r0, radius, angle=0 * degrees): scalar_mask_XY.py

it should be

ipasa = (Xrot)2 / (radiusx + 1e-15)2 + \ (Yrot)2 / (radiusy + 1e-15)2 < 1 or ipasa = (Xrot)2 / (radiusx2 + 1e-15) + \ (Yrot)2 / (radiusy2 + 1e-15) < 1 or ipasa = (Xrot)2 / (radiusx2) + \ (Yrot)2 / (radiusy2) < 1

Comments (3)

  1. traum tag

    It is

    ipasa = (Xrot)2 / (radiusx + 1e-15)2 + \ (Yrot)2 / (radiusy2 + 1e-15) < 1

    In def circle(self, r0, radius, angle=0 * degrees) in scalar_mask_XY.py

    it should be

    ipasa = (Xrot)2 / (radiusx + 1e-15)2 + \ (Yrot)2 / (radiusy + 1e-15)2 < 1

    or

    ipasa = (Xrot)2 / (radiusx2 + 1e-15) + \ (Yrot)2 / (radiusy2 + 1e-15) < 1

    or

    ipasa = (Xrot)2 / (radiusx2) + \ (Yrot)2 / (radiusy2) < 1

  2. LUIS MIGUEL SANCHEZ BREA repo owner

    Thank you for your comment. I have left the standard definition. I do not remember why I included 1e-15.

  3. Log in to comment