New feature: Night mode

Comments (15)

1. 

   Roman Telezhynskyi repo owner

   Only scene?

   • 2017-05-21T20:09:33+00:00
2. 

   legija reporter

   yes only the scene :)

   • 2017-05-21T20:10:20+00:00
3. 

   Roman Telezhynskyi repo owner

   • changed title to Allow change of scene background color

   • 2017-05-21T20:14:56+00:00
4. 

   Roman Telezhynskyi repo owner

   void QGraphicsScene::setBackgroundBrush

   http://stackoverflow.com/a/1165145/3045403

   • 2017-05-21T20:40:20+00:00
5. 

   Susan Spencer

   • changed milestone to TBD

   • 2017-06-17T22:17:00+00:00
6. 

   Susan Spencer

   • changed title to New feature: Select background color

   • 2017-06-17T22:32:30+00:00
7. 

   Roman Telezhynskyi repo owner

   • changed title to New feature: Night mode

   • 2017-06-18T05:51:57+00:00
8. 

   Roman Telezhynskyi repo owner

   https://github.com/ColinDuquesnoy/QDarkStyleSheet

   • 2018-03-12T11:52:27+00:00
9. 

   Emmanuel Nyachoke

   Hi thanks for the great software am playing around with it and the first thing I wanted was a dark theme so I downloaded the code to try add add it. Am new to both C++ and QT but this seems like something a person like me can do. Here is tape with the theme you suggested above . I could pick this up if its okay but I guess I will need to learn a bunch of things before I can get it done which is all I really want to do at the moment (Learn).

   • 2018-10-13T04:39:52+00:00
10. 

    Roman Telezhynskyi repo owner

    Hi @enyachoke, yes this is very useful feature for people who use the app everyday. There are a lot work to make support for dark theme. If you will have question feel free to ask.

    • 2018-10-13T12:08:40+00:00
11. 

    Emmanuel Nyachoke

    Hi @dismine I have started playing with https://github.com/ColinDuquesnoy/QDarkStyleSheet. So far I have the theme integrated and working though it make the canvas black which I don't think should be the case. I have also disabled native dialogs since it seems you can't style them. Is there a reason they where only disabled for linux?

    • 2018-10-28T17:47:19+00:00
12. 

    Emmanuel Nyachoke

    Here is screenshot of the preferences And the Valentina window

    Let me know if its okay to continue with this theme

    • 2018-10-28T17:54:09+00:00
13. 

    Roman Telezhynskyi repo owner

    Hi,

    make the canvas black which I don't think should be the case.

    No, the scenes must be dark. This is the biggest part of window and place which produce the most light.

    I have also disabled native dialogs since it seems you can't style them.

    We probably should not touch native dialogs. Left them as they are. There is reason why native dialogs look as they look.

    Is there a reason they where only disabled for linux?

    Because i had bug on Ubuntu. Also see issue #889 to know more about my plans regard to dialogs.

    Let me know if its okay to continue with this theme

    Yes, it looks promising. But i cannot merge your changes. You made commit to default branch. This is branch only releases. At least do commits to develop branch.

    • 2018-10-28T18:15:17+00:00
14. 

    Roman Telezhynskyi repo owner

    I think we need a functionality to provide CSS file for scene instead of hardcoding check for dark theme. Here is possible solution for parsing CSS https://stackoverflow.com/a/31593423/3045403

    • 2018-11-04T08:27:38+00:00
15. 

    Roman Telezhynskyi repo owner

    • changed status to closed

    Superseded by issue 67

    • 2020-10-19T08:47:57+00:00
16. Log in to comment