Improve feature: Rename Standard table to Multisize table

Comments (10)

1. 

   Susan Spencer

   • changed title to Improve feature: Rename Standard table to Multisize table
   • changed component to Tape app
   • changed milestone to v0.6.0

   • 2017-06-17T22:55:10+00:00
2. 

   Ronan Le Tiec

   I will take care of this issue.

   What we want:

   In the tape application, we want to change the strings of the GUI which contain "standard" to "multisize".

   Question

   Do we want to refactor the code as well, or we just take care of the GUI?

   • 2017-07-09T16:40:14+00:00
3. 

   Roman Telezhynskyi reporter

   Enough only to fix the GUI. But you can try to refactor the code as well if you have time for this. I don't mind.

   • 2017-07-09T17:05:12+00:00
4. 

   Susan Spencer

   Refactor in this issue or issue #428?

   • 2017-07-09T18:06:13+00:00
5. 

   Roman Telezhynskyi reporter

   In this. #428 is not trivial issue. I even don't understand now what it is all about.

   • 2017-07-09T18:08:55+00:00
6. 

   Susan Spencer

   #428 is not trivial issue.

   So if you refactor this code now, it will be rewritten later.
   However, refactoring now might make issue #428 easier to implement.
   It's up to you and Roman whether to refactor now or later.
   Read up on multisize tables on the forum to find out the background on this issue.

   • 2017-07-09T18:48:20+00:00
7. 

   Ronan Le Tiec

   I don't mind refactoring the code so that the variables / function names etc are changed from "standard" to "multisize".

   Roman probably knows best, if it's worth it or not? Will it make it easier for the future refactoring?

   I'll read in the forum like you adviced susan, to understand better what it's all about :-)

   • 2017-07-09T19:52:33+00:00
8. 

   Ronan Le Tiec

   I have made a pull request, I did the changes for the GUI and the code refactoring as well.

   I didn't know how to handle the change in /ifc/schema/pattern/ (with the measurementTypes values) so for the moment I didn't to anything there.

   Looking forward to hear what you think about my code Refactoring Roman :-) It wasn't easy because the string "standard" is found in a lot of files.

   • 2017-07-12T18:34:52+00:00
9. 

   Roman Telezhynskyi reporter

   • changed status to resolved

   Resolved issue #654. Improve feature: Rename Standard table to Multisize table.

   → <<cset eb9c73c2ccb2>>

   • 2017-07-13T08:36:03+00:00
10. 

    Roman Telezhynskyi reporter

    • removed milestone

    Removing milestone: v0.6.0 (automated comment)

    • 2018-10-23T09:17:32+00:00
11. Log in to comment